Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP chore-dependencies] Major npm dependency upgrades #159

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sergiitk
Copy link
Owner

@sergiitk sergiitk commented May 2, 2021

What's this PR do?

  • Node modules upgrade:
 devDependencies
   name                     range   from        to      url
 ◉ css-loader               latest  3.6.0    ❯  5.2.4   https://github.com/webpack-contrib/css-loader
 ◉ eslint-plugin-ava        latest  10.5.0   ❯  12.0.0  https://github.com/avajs/eslint-plugin-ava#readme
 ◉ mini-css-extract-plugin  latest  0.9.0    ❯  1.6.0   https://github.com/webpack-contrib/mini-css-extract-plugin
 ◉ node-sass                latest  4.14.1   ❯  5.0.0   https://github.com/sass/node-sass
 ◉ puppeteer-core           latest  5.0.0    ❯  9.0.0   https://github.com/puppeteer/puppeteer#readme
 ◉ react                    latest  16.14.0  ❯  17.0.2  https://reactjs.org/
 ◉ react-dom                latest  16.14.0  ❯  17.0.2  https://reactjs.org/
 ◉ sass-loader              latest  9.0.3    ❯  11.0.1  https://github.com/webpack-contrib/sass-loader
 ◉ sinon                    latest  9.2.4    ❯  10.0.0  https://sinonjs.org/
 ◉ style-loader             latest  1.3.0    ❯  2.0.0   https://github.com/webpack-contrib/style-loader
 ◉ webpack                  latest  4.46.0   ❯  5.36.2  https://github.com/webpack/webpack
 ◉ webpack-cli              latest  3.3.12   ❯  4.6.0   https://github.com/webpack/webpack-cli.git

 dependencies
   name                     range   from        to      url
 ◉ koa-views                latest  6.3.1    ❯  7.0.1   https://github.com/queckezz/koa-views#readme
  • Direct dependencies upgraded for
> yarn output, f.e:
├─ @babel/core@7.2.2
└─ winston@3.2.1

Backward-incompatible upgrades

warning " > eslint-config-airbnb@18.2.1" has unmet peer dependency "eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0".
warning " > optimize-css-assets-webpack-plugin@5.0.4" has incorrect peer dependency "webpack@^4.0.0".

module 1 example

  • Major|Minor|Patch update
  • Explanation

module 2 example

  • Attempted upgrade
    puppeteer latest 1.11.0 ❯ 1.12.1 https://github.com/GoogleChrome/puppeteer#readme
  • Broke acceptance tests, reverted to 1.11.0
  • Explanation

module 3 example

  • Secondary dependency
  • Attempted upgrade from a.b.0 to a.b.1, broke webpack prod build
  • Rolled back to a.b.0 using yarn resolutions
  • Ref related bug

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #159 (3b56700) into master (a9f49da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #159   +/-   ##
======================================
  Coverage    7.62%   7.62%           
======================================
  Files          25      25           
  Lines         538     538           
======================================
  Hits           41      41           
  Misses        497     497           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f49da...3b56700. Read the comment docs.

@sergiitk sergiitk force-pushed the chore/dependencies-update-major branch from 8435677 to d332e76 Compare May 3, 2021 00:28
css-loader               3.6.0    ❯  5.2.4
mini-css-extract-plugin  0.9.0    ❯  1.6.0
sinon                    9.2.4    ❯  10.0.
style-loader             1.3.0    ❯  2.0.0
eslint-plugin-ava  10.5.0   ❯  12.0.0
react              16.14.0  ❯  17.0.2
react-dom          16.14.0  ❯  17.0.2
@sergiitk sergiitk force-pushed the chore/dependencies-update-major branch from 9241584 to 60bece6 Compare May 3, 2021 05:25
@sergiitk sergiitk force-pushed the chore/dependencies-update-major branch from 60bece6 to 61537b4 Compare May 3, 2021 05:28
node-sass    4.14.1  ❯  5.0.0
sass-loader  9.0.3   ❯  11.0.1
Solves
warning " > eslint-config-airbnb@18.2.1" has unmet peer dependency
"eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0".
@sergiitk sergiitk temporarily deployed to pagerbeauty-staging May 3, 2021 06:46 Inactive
Repository owner deleted a comment Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant