Only link with blas when needed #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
force-pushed
the
feature/lazy-blas-dep
branch
3 times, most recently
from
2a730b3
to
e0e846b
Compare
Based on the included headers, pythran now automatically removes the blas dependency. Also do some cleanups (removing debug lines, some formatting, fix imatmul headers). Fix #2203
Also add a version skip for imatmul
serge-sans-paille
force-pushed
the
feature/lazy-blas-dep
branch
from
e0e846b
to
1eb42e3
Compare
|
@martibosch : this one is finally green. It should remove the dep on openblas on your project :-) |
|
unluckily I got the same error both locally and in github actions :( |
|
sorry, I made a mistake in the requirement syntax. After fixing, everything is working: https://github.com/martibosch/pylandstats/actions/runs/9077046472 should I release now with the git-branch requirement in pyproject.toml, or should i wait (e.g., maybe you remove feature branches or you plan a tagged release very soon). Thank you again! |
|
On Tue, May 14, 2024 at 03:02:43AM -0700, Martí Bosch wrote:
sorry, I made a mistake in the requirement syntax. After fixing, everything is
working: [1]https://github.com/martibosch/pylandstats/actions/runs/9077046472
should I release now with the git-branch requirement in pyproject.toml, or
should i wait (e.g., maybe you remove feature branches or you plan a tagged
release very soon).
Great! Release incoming this week or the week after :-)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the included headers, pythran now automatically removes the blas dependency.
Also do some cleanups (removing debug lines, some formatting, fix imatmul headers).
Fix #2203