-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Values #1353
Open
randomboolean
wants to merge
85
commits into
senx:master
Choose a base branch
from
randomboolean:INTERPOLATE
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Missing Values #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-r-p
suggested changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss: deduplication issues.
It can just fail, or deduplicate silently:
- with the full DEDUP logic ?
- with a SORT ?
Failing is simpler, and dedups are easy to check after sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Functionalities
The proposed enhancements extend the FILL operation to support univariate operations, filling missing timestamps within individual GTS based on specified gaps or empty buckets.
This approach fills existing functionality gaps:
Function Signatures
ticks
) or empty buckets.Note that the optional parameter
invalid.value
is the value returned by the evaluation function if the input timestamp is not in the function's support.Additional Fillers
MACROFILLER
When used in the context of the new univariate FILL mode, the macro encapsulated by MACROFILLER should be presented only with elements from the specified GTS, unlike in cross fill operations where it also receives elements from another GTS. The documentation will be revised to reflect this usage.
Macros as Filler Parameter
We have introduced the capability to use a macro directly as a filler parameter, (similar to a lambda filler function). In this setup, the macro must be designed to expect a GTS and a tick, and to return the filler value.