feat: MPD server #487
Draft
feat: MPD server #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkChaos
commented
Mar 23, 2024
| return c.srv.jukebox.TogglePlay() | ||
|
|
||
| case state == "1" || state == "0": | ||
| return c.srv.jukebox.SetPlay(state == "0") |
There was a problem hiding this comment.
Rename state to pause to make the comparison clear.
| return c.srv.jukebox.SetPlay(state == "0") | ||
|
|
||
| default: | ||
| return c.newErr(ackErrorArg, fmt.Errorf("play state must be 0 or 1, got: %s", state)) |
There was a problem hiding this comment.
Suggested change
| return c.newErr(ackErrorArg, fmt.Errorf("play state must be 0 or 1, got: %s", state)) | |
| return c.newErr(ackErrorArg, fmt.Errorf("pause state must be 0 or 1, got: %s", state)) |
| } | ||
|
|
||
| func doCmd(c *client, name string, args *argParser) error { | ||
| fmt.Println("->", args.line) |
There was a problem hiding this comment.
Needs to be removed/made into a proper log.
| ) | ||
|
|
||
| const ( | ||
| protocolVersion = "0" |
There was a problem hiding this comment.
Put something here when enough of the protocol is supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I did this as a proof-of-concept. There's no docs, not enough tests and comments, and what's actually implemented from the MPD API is pretty minimal. So I've marked this as a draft and wanted to get feedback before spending any more time on it.
The end goal for me is to be able to control the jukebox via any MPD client, since the jukebox support of Subsonic clients, is subpar from my experience. Ideally in the end being able to steal the queue from device to device, like is possible on the streaming giants.
Please let me know if this is something you'd be interested in merging. I'm willing to handle maintenance/future issues that pop up.