Update SkySat scripts #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorng
reviewed
May 28, 2024
|
|
||
| function evaluatePixel(sample) { | ||
| let NDVI = index(sample.NIR, sample.Red); | ||
| const indexVal = sample.dataMask === 1 ? NDVI : NaN; |
There was a problem hiding this comment.
I would mask infinite value as well. For example:
const indexVal = isFinite(NDVI) && sample.dataMask === 1 ? NDVI : NaN;
chorng
requested changes
May 28, 2024
| function evaluatePixel(sample) { | ||
| let NDVI = index(sample.NIR, sample.Red); | ||
| const indexVal = sample.dataMask === 1 ? NDVI : NaN; | ||
| let id_default = valueInterpolate(NDVI, |
There was a problem hiding this comment.
I would remove the dataMask in the valueInterpolate and include the dataMask later. In this case we can avoid repeatation.
| ); | ||
|
|
||
| return { | ||
| default: id_default, |
There was a problem hiding this comment.
Include dataMask as the following:
default: id_default.concat(sample.dataMask),|
|
||
| function setup() { | ||
| return { | ||
| input: ["Red", "NIR", "dataMask"], |
| var NDVI = index(sample.nir, sample.red) | ||
| return valueInterpolate(NDVI, | ||
| let NDVI = index(sample.NIR, sample.Red); | ||
| let id_default = valueInterpolate(NDVI, |
There was a problem hiding this comment.
Same as the eob script. I would remove the dataMask from valueInterpolate function and include dataMask later
| ]); | ||
|
|
||
| return { | ||
| default: id_default, |
There was a problem hiding this comment.
return {
default: id_default.concat(sample.dataMask),
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated / added the NDVI scripts
script.jswhich contains "normal" visualization without additional outputs needed for EO Browser statistics and histogrameob.jswhich contains additional outputs needed for EO Browser statistics and histogramraw.jswhich just outputs raw NDVI values