add custom scripts for arps sandbox data #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorng
requested changes
May 8, 2024
There was a problem hiding this comment.
Please have a look at the /contribute dir and follow the instruction there.
It is highly recommended to prepare visuaisation (script.js), raw (raw.js), and statistical feature enabled (eob.js) scripts to make it eaiser to be adopted by users. Please also make sure the formatting is consistent, e.g., the spaces and the indents.
You could also try to local build your changes following the instruction here. By doing this you can test if your changes work as your expectation.
chorng
requested changes
May 21, 2024
* remove redundant curly brackets in setup function * format color ramp of ndvi script * remove redundant if condition of true color cloud masked script
chorng
approved these changes
May 22, 2024
|
Thank you @chorng for the detailed review! I did not pay heed to the importance of formatting, so thank you for pointing multiple changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds custom evalscripts for analysis ready planetscope's new sandbox dataset.