new silenced setting attributes addition #5049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
|
@chavakula Looks good! I believe this change requires a changelog entry. |
Yes i guess,
Hi @fguimond , i guess we require entry into changelog 6. any specific version planned to release?. |
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
|
@fguimond change log added. Please have a look if anything is required. |
fguimond
reviewed
Mar 7, 2024
| // Store is an implementation of the sensu-go/backend/store.Store iface. | ||
| type Store struct { | ||
| client *clientv3.Client | ||
| keepalivesPath string | ||
| cfg Config |
There was a problem hiding this comment.
I'm wondering if this is the right place to have this config property. It seems to be used exclusively in silenced_store.go so why not have it there instead?
Hmmm I see why. I know some of the validation logic was there already but I wonder if it could be performed elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
as per required mentioned in https://github.com/sensu/sensu-go-extras/issues/16
Why is this change necessary?
feature request mentioned in https://github.com/sensu/sensu-go-extras/issues/16
Does your change need a Changelog entry?
Do you need clarification on anything?
Were there any complications while making this change?
Have you reviewed and updated the documentation for this change? Is new documentation required?
How did you verify this change?
Done manual testing using available options to create silenced
Is this change a patch?