Add VMware to agent cloud discovery #4748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committer: Michael Kennedy <michael_l_kennedy@me.com> Signed-off-by: Michael Kennedy <michael_l_kennedy@me.com> Adding support for VMware as a Cloud Provider returned by GetCloudProvider(ctx).
|
This PR correlates with #4747. |
ccressent
changed the title
|
@mkennedy85 thanks for the PR! We do require that contributers sign commits with DCO, which is a promise that you are authorized to make the commits under our MIT license. Can you please sign DCO and force push? Thanks! |
|
cc @portertech to take a gander. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer: Michael Kennedy michael_l_kennedy@me.com
Signed-off-by: Michael Kennedy michael_l_kennedy@me.com
Adding support for VMware as a Cloud Provider returned by GetCloudProvider(ctx).
What is this change?
Add VMware as a Cloud Provider applied to entity metadata through agent discovery.
Why is this change necessary?
The agent is capable of platform discovery and supports AWS and GCP. This same approach is capable and should detect VMware as a platform cloud provider.
Does your change need a Changelog entry?
Yes and the Changelog entry has been added as specified in the contribution guidelines.
Do you need clarification on anything?
Were there any complications while making this change?
The change is rather trivial and does not introduce error conditions, but rather simply detects a possible output returned from an existing exec command.
Have you reviewed and updated the documentation for this change? Is new documentation required?
There did not appear to be documentation pertaining to this agent behavior, so no updates have been made.
How did you verify this change?
This change was verified on a Linux host running on a VMware vSphere 6.7 hypervisor, and the output was verified from the exec command and then validated using the existing function.
Is this change a patch?
No it is not.