Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce execute verb for check #3458 #4290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjiderhamn
Copy link
Contributor

What is this change?

Untested starting point for implementing execute verb to fix #3458.

Why is this change necessary?

See #3458

Does your change need a Changelog entry?

Yes

Do you need clarification on anything?

This is only meant as a starting point, to get you motivated to get the implementation moving. Don't know what other bits may be lacking.

Were there any complications while making this change?

No

Have you reviewed and updated the documentation for this change? Is new documentation required?

https://docs.sensu.io/sensu-go/latest/operations/control-access/rbac/ should be updated.

How did you verify this change?

Untested starting point only

Is this change a patch?

No

@echlebek
Copy link
Contributor

Thanks for the patch! We'd need to base this on main and not release/6.3, which is meant to be stable. As a starting point, it looks good, but appears to need testing fixups.

@mjiderhamn mjiderhamn changed the base branch from release/6.3 to main May 19, 2021 06:56
Signed-off-by: Mattias Jiderhamn <mattias@jiderhamn.se>
@mjiderhamn
Copy link
Contributor Author

Rebased on main

@calebhailey
Copy link

This is great. Thanks!

@echlebek echlebek marked this pull request as draft June 1, 2021 04:32
@echlebek
Copy link
Contributor

echlebek commented Jun 1, 2021

I've converted the PR to a draft to indicate its partial status.

@portertech portertech requested a review from echlebek July 6, 2021 18:26
@calebhailey calebhailey added this to the 6.6.0 milestone Nov 1, 2021
@portertech portertech modified the milestones: 6.6.0, 6.next Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdhocRequest permissions are aliased to CheckConfig permissions
4 participants