Disable cross-origin check #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The viewer for PDF.js does its own cross-origin checks, refusing to load any remote PDFs, which stops the viewer loading PDFs from CDNs or remote storage locations, such as S3.
|
I don't think it's the way to comment out the whole validation code. I think the solution would be: var HOSTED_VIEWER_ORIGINS = ['*'];(at line 7145) Or delete the all of the validations, but I think there's a reason why this is in here. @senny What do you think? |
|
@MattFenelon can't we follow the suggestion in #12 and make |
Open
|
Closed by #20 |
|
What's... the latest on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The viewer for PDF.js does its own cross-origin checks, refusing to load any remote PDFs, which stops the viewer loading PDFs from CDNs or remote storage locations, such as S3.