New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reply to list support #1096
Open
MxFlorin
wants to merge
4
commits into
sendgrid:main
Choose a base branch
from
MxFlorin:add-reply-to-list-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a project requiring multiple reply-to addresses. Is there any update on this PR? |
childish-sambino
changed the title
feat!: add reply to list support
feat: add reply to list support
Jul 29, 2022
Comment on lines
+1010
to
+1025
foreach ($list as $l) { | ||
if ($l instanceof ReplyTo ) { | ||
$this->reply_to_list[] = $l; | ||
} else { | ||
if (is_array($l)) { | ||
if (!empty($l) && $l['email'] !== '') { | ||
$this->reply_to_list[] = new ReplyTo($l['email'], $l['name']); | ||
} | ||
} else { | ||
if ($l !=='') { | ||
$this->reply_to_list[] = new ReplyTo($l); | ||
} | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition! Could you add some unit tests to validate the logic here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR add reply_to_list support to the library.
Checklist
If you have questions, please file a support ticket.