Casts values to double - Fix for ticket SNAP-1045 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. But this is only a small part of the complete fix. |
|
Ok. I should be able to implement the remainder of the changes needed this week and update this pull request with the new commits when I complete the necessary changes. |
TonioF
requested changes
Mar 13, 2019
| @@ -417,9 +417,9 @@ private void updateTargetResolutionTargetWidthAndHeight() { | |||
|
|
|||
| private void reactToSourceProductChange(Product product) { | |||
| if (product != null) { | |||
| resolutionSpinner.setValue(determineResolutionFromProduct(product)); | |||
| resolutionSpinner.setValue(new Double(determineResolutionFromProduct(product))); | |||
There was a problem hiding this comment.
Rather than creating a Double object here, make determineResolutionFromProduct return a double in the first place.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Resampling dialog to now successfully open and resample imagery, casting values to Double.