fix: Model JSX component instantiation as a call #10236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted inline, modeling `<Foo x={y}>{bar}</Foo>` as `Foo({x:y,
children: [bar]})` is a reasonably accurate approximation of what
actually happens at runtime. It will only work for functional
components, but those are common. It will take more work to correctly
model older ways of creating React components.
I believe this has no effect on the OSS behavior. It will only affect
intraprocedural analysis, so no test results should change here.
Test plan: Automated tests
|
PR checklist:
If you're unsure about any of this, please see: |
You mean "inter-procedural" (intra -> inter). |
IagoAbal
pushed a commit
that referenced
this pull request
May 16, 2024
…prietary#1510) As noted inline, modeling `<Foo x={y}>{bar}</Foo>` as `Foo({x:y, children: [bar]})` is a reasonably accurate approximation of what actually happens at runtime. It will only work for functional components, but those are common. It will take more work to correctly model older ways of creating React components. Replaces #10236 Test plan: Automated tests synced from 413902d50aa48f9877b8ff8dea925d1de5f2e14c
aryx
pushed a commit
that referenced
this pull request
May 16, 2024
…prietary#1510) As noted inline, modeling `<Foo x={y}>{bar}</Foo>` as `Foo({x:y, children: [bar]})` is a reasonably accurate approximation of what actually happens at runtime. It will only work for functional components, but those are common. It will take more work to correctly model older ways of creating React components. Replaces #10236 Test plan: Automated tests synced from 413902d50aa48f9877b8ff8dea925d1de5f2e14c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted inline, modeling
<Foo x={y}>{bar}</Foo>asFoo({x:y, children: [bar]})is a reasonably accurate approximation of what actually happens at runtime. It will only work for functional components, but those are common. It will take more work to correctly model older ways of creating React components.I believe this has no effect on the OSS behavior. It will only affect intraprocedural analysis, so no test results should change here.
Test plan: Automated tests