Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pro: tainting: Track taint through tuple/list (un)packing #10175

Closed
wants to merge 13 commits into from

Conversation

IagoAbal
Copy link
Collaborator

@IagoAbal IagoAbal commented Apr 27, 2024

DRAFT

def foo():
  return (ok, tainted)

def bar():
  x = foo()
  sink(x[1])

Copy link
Contributor

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to changelog.d for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@IagoAbal IagoAbal changed the title pro: tainting: Track taint through list/tuple construction and unpacking pro: tainting: Track taint through tuple/list (un)packing Apr 27, 2024
@IagoAbal IagoAbal force-pushed the iago/taint-shapes branch 6 times, most recently from 5073754 to 3af05c3 Compare May 7, 2024 11:17
@r2c-argo
Copy link
Contributor

r2c-argo bot commented May 8, 2024

semgrep-compare-github-h9aqp results

Ran benchmark on 38 repositories

The number of findings differs for 3 repos

Whole benchmark is 2.1% slower (a bit of noise is expected)

Relative speed improvement is 0.99 on average

  • 3% of scans are significantly faster
  • 5% of scans are significantly slower

Relative memory improvement is 1.00 on average

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants