Fix galaxy requirement.yml paths #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a change to the way of how the path of the Ansible Galaxy requirements.txt is resolved.
For roles, it uses the base path of the cloned repository. This PR does NOT change that, but it updates the code to use the
pathlibrary instead of string concatenation to build the path.For collections, Semaphore uses the path of the playbook file as a base path to locate the requirements.txt. This is counterintuitive to the roles. Therefore, this PR changes this behaviour to also use the base path of the cloned repository.
This is especially useful when people have their playbooks inside a subfolder.