New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#258 Improvements for table pagination, search input and filters. #311
base: master
Are you sure you want to change the base?
Conversation
@criske thank you for your Pull Request. I'll assign someone to review it soon. |
@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
@criske thanks! However, we will not merge this yet because these are very big changes which I would like to cover in the next QA round after we go to Prod. Let's leave the PR open, I closed the Issue. I also sent a bonus of 2 more hours since this is clearly more than 1h work :D |
@amihaiemil thanks! :D, also can I fix here the date filtering in "Invoices" table, now there is more time...? |
@criske yes, sure :D |
@amihaiemil Don't forget to close this ticket before the deadline (2021-01-06T11:48:50). You are past the first half of the allowed period. |
@charlesmike deregister |
@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore. |
…ters. - fixed bug where invoices table searching was disabled, thus making search builder plugin to not work.
…ters. - fixed bug where invoices table searching was disabled, thus making search builder plugin to not work.
# Conflicts: # src/main/resources/public/js/getAndAddContracts.js
# Conflicts: # src/main/resources/public/css/main.css
closes #258
moved "Show entries per page" before the pagination
tweaks on pagination ux (smaller buttons, icons for next/previous page).
project contracts can be searched only by "Contributor" and search input has placeholder now.
"options" column in "Contracts" can't be ordered anymore.
used datatables
Search Builder
plugin to filter dates (assigned
anddeadline
) in "Tasks" table andcreated
in "Invoices" table.since is the last day before this puzzle deadline, left puzzle to fix
created
date filtering in "Invoices", somehow is not working...