Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#258 Improvements for table pagination, search input and filters. #311

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

criske
Copy link
Contributor

@criske criske commented Jan 3, 2021

closes #258

  • moved "Show entries per page" before the pagination

  • tweaks on pagination ux (smaller buttons, icons for next/previous page).

  • project contracts can be searched only by "Contributor" and search input has placeholder now.

  • "options" column in "Contracts" can't be ordered anymore.
    contracts_table

  • used datatables Search Builder plugin to filter dates (assigned and deadline) in "Tasks" table and created in "Invoices" table.
    date_filter


since is the last day before this puzzle deadline, left puzzle to fix created date filtering in "Invoices", somehow is not working...

@charlesmike
Copy link

@criske thank you for your Pull Request. I'll assign someone to review it soon.

@charlesmike
Copy link

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2021-01-06T11:48:50.146142.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@amihaiemil
Copy link
Member

@criske thanks! However, we will not merge this yet because these are very big changes which I would like to cover in the next QA round after we go to Prod.

Let's leave the PR open, I closed the Issue. I also sent a bonus of 2 more hours since this is clearly more than 1h work :D

@criske
Copy link
Contributor Author

criske commented Jan 4, 2021

@amihaiemil thanks! :D, also can I fix here the date filtering in "Invoices" table, now there is more time...?

@amihaiemil
Copy link
Member

@criske yes, sure :D

@charlesmike
Copy link

@amihaiemil Don't forget to close this ticket before the deadline (2021-01-06T11:48:50). You are past the first half of the allowed period.

@amihaiemil
Copy link
Member

@charlesmike deregister

@charlesmike
Copy link

@charlesmike deregister

@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore.

…ters.

- fixed bug where invoices table searching was disabled, thus making search builder plugin to not work.
…ters.

- fixed bug where invoices table searching was disabled, thus making search builder plugin to not work.
# Conflicts:
#	src/main/resources/public/js/getAndAddContracts.js
# Conflicts:
#	src/main/resources/public/css/main.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for table pagination, search input and filters
3 participants