Hotfix Issue #52 #53
Open
Hotfix Issue #52 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2023 11:28
- Changed return value from null to empty string in `UriParser::setQueryUri` method, if query params were not pass. It needs, so that `Paginator::setQueryUri` str_replace get empty string instead of `null` and does not crash.
- Added additional step for identification current page before processing pagination query in the `QueryBuilder::basePaginate` method. It needs, because the `QueryBuilder::basePaginate` is private and is called only once and only in this class. The method calls without `$page` parameter passing, so that the `$page` will always be `1` and the `Paginator::items` will have incorrect items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UriParser::setQueryUrimethod, if query params were not pass. It needs, so thatPaginator::setQueryUristr_replace get empty string instead ofnulland does not crash.QueryBuilder::basePaginatemethod. It needs, because theQueryBuilder::basePaginateis private and is called only once and only in this class. The method calls without$pageparameter passing, so that the$pagewill always be1and thePaginator::itemswill have incorrect items.