Fix deserialization of unknown extensions #31
Conversation
OpenSSH 8.9 ssh client started sending EXTENSION commands. Unfortunately ssh-agent.rs didn't deserialize them correctly and even though these extensions were optional the agent didn't work. This patch adjusts the deserialization of extension contents to properly capture all bytes and includes a test code observed in the wild. Fixes #30.
|
Thanks for working on a fix! I hope this pull request gets reviewed and merged soon, so that we can unblock people from going to OpenSSH 8.9. |
|
TBH I wouldn't count on that. I've contacted the maintainers (getting e-mails from git commits) but haven't heard back. Since I needed this and a couple of other features I forked the repo and merged outstanding PRs there. Just in case you're critically dependent on this here's the URL: https://github.com/wiktor-k/ssh-agent-lib |
|
Yeah, I've found that fork after my comment. Will migrate over. Thanks for taking over! Honestly, the least those guys could do is add a not-maintained badge to the repository and mark it as such in |
|
Done. I just did exactly what you suggested. Please take into account that this project is not for profit and we have other concerns to address in our lives. Our intention is to eventually continue maintaining it, but currently it's impossible for us. |
OpenSSH 8.9 ssh client started sending EXTENSION commands. Unfortunately ssh-agent.rs didn't deserialize them correctly and even though these extensions were optional the agent didn't work.
This patch adjusts the deserialization of extension contents to properly capture all bytes and includes a test code observed in the wild.
Fixes #30.