Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null replicas in RequestPartition #1270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow null replicas in RequestPartition #1270

wants to merge 1 commit into from

Conversation

leizor
Copy link

@leizor leizor commented Mar 5, 2024

The replicas slice was declared as an empty slice which precludes passing a nil slice in the case of wanting to cancel an ongoing assignment.

@leizor
Allow null replicas in RequestPartition
0fc45b3 
The `replicas` slice was declared as an empty slice which precludes
passing a nil slice in the case of wanting to cancel an ongoing
assignment.
@leizor leizor marked this pull request as ready for review March 5, 2024 18:40
@leizor
Copy link
Author

leizor commented Mar 5, 2024

The TestReaderReadCompactedMessage test is failing but it passes on my local machine and I think is unrelated to the change in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@leizor