Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1093
Not really familiar with the code base, but I figured out that there are 2 different implementation of the Kafka protocol, so I put the same logic to both "conn.go" and "transport.go".
So far I could only test this with the "Reader" so the code in "conn.go" seems to work.
I tried different percentages, but ended up using a random %80-%90 percent of session lifetime to trigger re-authentication. A static %90 sometimes caused the "stopped heartbeat" problem with rebalances etc...