Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a working example with trunk #561

Conversation

seanybaggins
Copy link

Closes issue #535.

Created an example that uses trunk instead of the cargo make setup.

Some questions...
Is it worth making or replacing examples to use trunk?

Things that should still be done...
Update documentation for users to use trunk if that is a direction that is chosen.

@MartinKavik
Copy link
Member

MartinKavik commented Dec 3, 2020

@seanybaggins Thanks for the PR!

Is it worth making or replacing examples to use trunk?

  • Yeah, everything should be slowly migrated to use Trunk (including docs and quickstart(s)).

I would just modify the original examples and remove as much code as possible. Less code => less confusion, less bugs, better maintainability.

But there are three main blockers for Trunk integration:

  1. wasm-opt integration - Leverage wasm-pack to handle wasm-bindgen installs & other awesomeness trunk-rs/trunk#5 (comment)
  2. Clean previous build artifacts - Clean build previous artifacts after successful build trunk-rs/trunk#69
  3. Resolve infinite watch & rebuild loop - Fix infinite watch loop. trunk-rs/trunk#84

We can live without automatic wasm-bindgen installation, auto-reloading etc., but these three things reduce developer experience and app quality significantly and I can't recommend to use it for production at the moment.

I unfortunately doesn't have a capacity to resolve those problems in the near future, so we would be glad for any help. Then we can continue with this PR.
Does it make sense?

@seanybaggins
Copy link
Author

Total sense. I will see if I can work on any of the issues you mentioned. Thanks for making Seed :)

@flosse
Copy link
Member

flosse commented Apr 7, 2022

I also like the idea of using trunk as a standard tool. Instead of creating an additional example, I would update the documentation and migrate all the examples. So I'm closing this topic now and linking it to #611.

@flosse flosse closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants