Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix small syntax errors in the gperf script #428

Closed
wants to merge 1 commit into from

Conversation

huajingyun01
Copy link
Contributor

hi,when I compile libseccomp, the error is as follows:

  CC       libseccomp_la-syscalls.lo
  GEN      syscalls.perf
sed: can't find label for jump to 'r1}'
make[3]: *** [Makefile:1425: syscalls.perf] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:935: all-recursive] Error 1

more detail:

~/test/libseccomp/src$ cat ./syscalls.csv | grep -v '^#'|nl -ba -s, -v0 | sed -e '{s|^[[:space:]]\+\([0-9]\+\),\([^,]\+\),\(.*\)|\2,\1,\3|;};' -e '{:r1; {s|\([^,]\+\)\(.*\)[^_]PNR|\1\2,__PNR_\1|g;}; t r1};' -e '{s|,KV_|,SCMP_KV_|g;};'
sed: can't find label for jump to 'r1}'
~/test/libseccomp/src$ 

Signed-off-by: Jingyun Hua <huajingyun@loongson.cn>
@pcmoore pcmoore changed the title fix small syntax errors BUG: fix small syntax errors in the gperf script Apr 12, 2024
@pcmoore pcmoore added the bug label Apr 12, 2024
@pcmoore pcmoore added this to the v2.6.0 milestone Apr 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.474%. remained the same
when pulling 9452b9b on huajingyun01:main
into 47ca644 on seccomp:main.

Copy link
Member

@pcmoore pcmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we've never seen this error before, but this patch looks good to me. As a note to @drakenclimber and myself, when merging please adjust the subject line to "gperf: fix sed syntax" or similar.

Acked-by: Paul Moore <paul@paul-moore.com>

@drakenclimber
Copy link
Member

Pushed to main in commit 99bd9e5. Thanks, @huajingyun01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants