Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark project as abandoned #2040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinsotirov
Copy link

No description provided.

@aotaduy
Copy link

aotaduy commented Oct 30, 2023

Hi, @martinsotirov why you think it will never be compatible?

What is the issue with the architecture? can you please elaborate a little more?

We are trying to keep this project alive since we are using it in some of our applications. We even created a fork and published some ng14 compatible packages. But didnt went for the ng15 migration yet .

Thanks!

@martinsotirov
Copy link
Author

martinsotirov commented Oct 30, 2023

@aotaduy, I state the reason in my change to the README:

Due to a fundamental architecture conflict with newer versions of Angular, this project is no longer maintained. If you're using Angular 15 or 16, you should look for alternatives like @angular/google-maps or @ng-maps/google.
The last known Angular version that is compatible with this project is Angular 14. Feel free to fork the repository if you wish to continue its development.

Due to the fact that Ivy is Angular's only rendering engine since v15, this project would require a considerable rewrite. Also the author isn't interested in maintaining it or even accepting PRs.

If you manage to get it working on Angular v15+, I'm sure many people (myself included) would be interested in using your fork.

@aotaduy
Copy link

aotaduy commented Oct 30, 2023

I understand that the author is not intrested, but not sure why The ivy engine would require so many changes.

We have only migrated to ng14, but in the near future will try to make it work with Ivy. Will come back then.

I've seen some pull requests that migrtated to 15 but they only changed the angular version. Looks like this is not enough right?

Thanks for your response !

@aotaduy
Copy link

aotaduy commented Oct 31, 2023

Hi @martinsotirov i just made a new version with angular 15 and tested in our app, looks like is working fine.
We only use agm-core and agm-drawing so didn't tested the other packages but migrated them anyway

you can find the packages here
https://www.npmjs.com/package/@grupo-san-cristobal/agm-core/v/15.0.5
https://www.npmjs.com/package/@grupo-san-cristobal/agm-drawing/v/15.0.5

Made a stackblitz test and it also works fine
https://stackblitz.com/edit/angular-google-maps-ng15?file=package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants