Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout du TP2 #2

Merged
merged 10 commits into from Mar 12, 2024
Merged

Ajout du TP2 #2

merged 10 commits into from Mar 12, 2024

Conversation

sebclrsn
Copy link
Owner

J'ai ajouté les pre-commit hooks en plus du TP2, comme ca ils devront les faire tourner avant de pouvoir pusher, qu'est-ce que tu en penses?

LoicRiegel
LoicRiegel reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@LoicRiegel LoicRiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, pre-commit est bien. Je dirai même de mettre en place un pipeline tout simple GitHub action pour checker les pre-commits :) Je peux le faire vite fait sur une autre branche si tu veux :)

SInon on s'appelle peut-être cette aprem

TP2/README.md Outdated Show resolved Hide resolved
TP2/README.md Outdated Show resolved Hide resolved
TP2/imu_analysis/reader.py Show resolved Hide resolved
TP2/imu_analysis/reader.py Outdated Show resolved Hide resolved
sebclrsn and others added 3 commits March 11, 2024 12:31
@sebclrsn @LoicRiegel
Update TP2/imu_analysis/reader.py
44eda28 
Co-authored-by: Loïc Riegel <96702577+LoicRiegel@users.noreply.github.com>
@sebclrsn @LoicRiegel
Update TP2/README.md
3c4d1db 
Co-authored-by: Loïc Riegel <96702577+LoicRiegel@users.noreply.github.com>
@sebclrsn @LoicRiegel
Update TP2/README.md
56867b7 
Co-authored-by: Loïc Riegel <96702577+LoicRiegel@users.noreply.github.com>
@sebclrsn
Copy link
Owner Author

Oui, pre-commit est bien. Je dirai même de mettre en place un pipeline tout simple GitHub action pour checker les pre-commits :) Je peux le faire vite fait sur une autre branche si tu veux :)

SInon on s'appelle peut-être cette aprem

C'est vrai qu'on pourrait vu que le repo est publique, bonne idée!
Si tu es partant je te laisse mettre ca en place ;)

@LoicRiegel
Copy link
Collaborator

C'est vrai qu'on pourrait vu que le repo est publique, bonne idée! Si tu es partant je te laisse mettre ca en place ;)

Fait! Voir PR #3

sebclrsn and others added 3 commits March 11, 2024 13:39
@sebclrsn sebclrsn merged commit 87bf3bb into main Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoicRiegel LoicRiegel LoicRiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebclrsn @LoicRiegel