Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the generic types #29

Closed
wants to merge 1 commit into from
Closed

Conversation

stof
Copy link
Contributor

@stof stof commented Mar 29, 2024

phpstan does not like when you have a template type for which the bound (which was mixed before due to being omitted) is not compatible with the native parameter type. Because of that, it would ignore the @psalm-template annotation and then cause issues with the @param-out type.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4a20654) to head (85ffb7a).

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #29   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        16        16           
===========================================
  Files              1         1           
  Lines             37        37           
===========================================
  Hits              37        37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

Cherry-picked into 5.0 and merged to main from there.

@stof stof deleted the patch-1 branch March 29, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants