Make export of objects customizable #56
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 49 60 +11
===========================================
Files 1 2 +1
Lines 159 179 +20
===========================================
+ Hits 159 179 +20 ☔ View full report in Codecov by Sentry. |
sebastianbergmann
force-pushed
the
customizable-object-export
branch
from
794322c
to
ac6d770
Compare
|
lgtm |
sebastianbergmann
force-pushed
the
customizable-object-export
branch
from
db75879
to
af726e4
Compare
sebastianbergmann
force-pushed
the
customizable-object-export
branch
from
27502d4
to
a05140e
Compare
| $buffer = $this->defaultObjectExport($value, $processed, $indentation); | ||
| } | ||
|
|
||
| return $class . ' Object #' . spl_object_id($value) . ' (' . $buffer . ')'; |
There was a problem hiding this comment.
one more thing I just noticed.
the $class . ' Object #' prefix will only be present in "root objects". in custom object exporters this $class . ' Object #' format needs to be replicated, even if the custom exporter delegates export back to the built-in one.
There was a problem hiding this comment.
Should we deal with that in Exporter::exportObject() or should we trust implementors of custom object exporters to do the right thing?
There was a problem hiding this comment.
I don't see a way how Exporter::exportObject() could do that in a way which would even work when custom exporters would delegate exporting of some stuff back to the exporter object.
Maybe we just need a test-case so we can see whether it works already or what a custom ObjectExporter needs todo to get it right
There was a problem hiding this comment.
Maybe the problem would be less theoretic if we try to implement a real world exporter
Maybe @BladeMF could try his use-case..?
There was a problem hiding this comment.
I like that ... and would rather not make a release without this feature having been validated through real world use cases.
Follows sebastianbergmann/phpunit#5773 (comment).