Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding overwriting of private members redeclared in derived classes #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

exeba
Copy link

@exeba exeba commented May 6, 2020

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.41%. Comparing base (efa4b59) to head (fcc13b2).
Report is 349 commits behind head on main.

❗ Current head fcc13b2 differs from pull request most recent head 10a5d0e. Consider uploading reports for the commit 10a5d0e to get more accurate results

Files Patch % Lines
src/Exporter.php 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #35      +/-   ##
============================================
- Coverage     98.09%   97.41%   -0.69%     
- Complexity       42       46       +4     
============================================
  Files             1        1              
  Lines           105      116      +11     
============================================
+ Hits            103      113      +10     
- Misses            2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants