Resolves issue #133: Add option to parse lastmod and changefreq and priority #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the merge. I just thought of the fact that i didn't include the |
|
@tijevlam think it got released without the lib folder, @seantomburke can we have a fix for this? |
Oh good call, yes need to include the lib folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the option to parse more than just the urls in the ourput also. Decided to add it myself and create this pull request. I've added it to the Readme and tests as well. All tests were passed.
It actually gives the user to specify the fields to be included in the output by providing
fields, a new object, available in the settings/constructor. I've not limited it to lastmod, changefreq and priority because technically you are allowed to have more and other fields as well in a sitemap.xml. Theloccan even be excluded by either leaving it out of the fields parameter or by setting it tofalse.