Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supports wasm fetch credentials #1227

Merged
merged 3 commits into from Apr 6, 2021
Merged

Conversation

xusd320
Copy link

@xusd320 xusd320 commented Mar 24, 2021

Support set fetch credentials in wasm.

@xusd320 xusd320 force-pushed the master branch 3 times, most recently from d92087f to e9ec241 Compare March 24, 2021 08:48
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Would it be possible to do similar to the other wasm-specific methods that we've added before. I think there's some around CORS mode. Specifically, don't expose the RequestCredentials type, since that would prevent us from ever changing to a different internal dependency or version of it.

@xusd320
Copy link
Author

xusd320 commented Mar 25, 2021

Thanks for the PR!

Would it be possible to do similar to the other wasm-specific methods that we've added before. I think there's some around CORS mode. Specifically, don't expose the RequestCredentials type, since that would prevent us from ever changing to a different internal dependency or version of it.

Do you mean we provide three methods like fetch_credentials_same_origin, fetch_credentials_omit, fetch_credentials_ include? And I will delete the RequestCredentials export.

@xusd320 xusd320 force-pushed the master branch 2 times, most recently from 27a0be1 to adb5cc5 Compare March 25, 2021 03:30
src/wasm/request.rs Outdated Show resolved Hide resolved
@xusd320 xusd320 force-pushed the master branch 2 times, most recently from 9eb19cd to fd5ab44 Compare March 28, 2021 03:05
@xusd320
Copy link
Author

xusd320 commented Mar 28, 2021

The cargo check has been failed, seems we need to upgrade rust toolchain to 1.46.0 or later to solve that.

@xusd320 xusd320 force-pushed the master branch 2 times, most recently from d21369d to 0d251a9 Compare March 28, 2021 05:05
@xusd320
Copy link
Author

xusd320 commented Mar 28, 2021

Sorry for my PUSH-FORCE which makes the CI info disappear , I just want to keep the commit clean.

We can reproduce the cargo check failure with rust 1.45.2 and the latest master branch of this repo. The reason is that socket2 of this crate's dependency was been upgraded to 0.4.0, which can't compile on rust 1.45.2, related issue is here

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates (apologies, I was away for a week, catching up again). I'll restart CI and this should be good to go.

@seanmonstar seanmonstar merged commit 1614c5e into seanmonstar:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants