Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the V3 Core #209

Open
wants to merge 94 commits into
base: main
Choose a base branch
from
Open

Introducing the V3 Core #209

wants to merge 94 commits into from

Conversation

seandstewart
Copy link
Owner

No description provided.

This change migrates all of the Deserializer factory's logic into pre-written routines rather than generated in-memory. This paves the way for compiling our serdes protocols using cython. It also opens a path to allow users to define their own custom Routines.
Also use orjson where possible for serialization.
Similar to serde/des, this change migrates us away from purely generated code for our serialization routines. This has the advantage of improved debugging, better visibility in to code-coverage, opens the door for an official developer API for providing custom routines, and allows us to see performance gains from a Cython-compiled version of typical.
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 91.15938% with 350 lines in your changes are missing coverage. Please review.

Project coverage is 91.79%. Comparing base (97eec30) to head (d0f90a7).

Files Patch % Lines
src/typical/inspection.py 68.73% 89 Missing and 12 partials ⚠️
src/typical/magic/schema/jsonschema/builder.py 69.56% 49 Missing and 14 partials ⚠️
src/typical/serde/ser/routines.py 81.85% 32 Missing and 9 partials ⚠️
src/typical/serde/des/routines.py 96.36% 9 Missing and 8 partials ⚠️
src/typical/constraints/core/validators.py 89.47% 11 Missing and 3 partials ⚠️
src/typical/magic/schema/abc.py 78.68% 12 Missing and 1 partial ⚠️
src/typical/constraints/engine.py 94.50% 5 Missing and 5 partials ⚠️
src/typical/env.py 65.38% 8 Missing and 1 partial ⚠️
src/typical/magic/schema/builder.py 64.00% 8 Missing and 1 partial ⚠️
src/typical/compat.py 88.13% 7 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   94.74%   91.79%   -2.96%     
==========================================
  Files          37       75      +38     
  Lines        4376     5069     +693     
  Branches      886      796      -90     
==========================================
+ Hits         4146     4653     +507     
- Misses        142      320     +178     
- Partials       88       96       +8     
Flag Coverage Δ
unittests 91.57% <91.00%> (-3.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant