Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert a new Skiplist implementation, repair links and add self-hosted images #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MauriceGit
Copy link

@MauriceGit MauriceGit commented Jul 14, 2018

Hello Sean,

as discussed per mail, here is my pull-request.

What has changed:

  • Included my own Skiplist implementation (including description).
  • Added two more functions that are close real-world cases (random Inserts, random Deletes) that nicely show the logarithmic behaviour of insertion/deletion across all benchmarks.
  • Attached the actual output.csv, openOffice table and generated graphs in the graphs folder.
  • All graphs in the README are now self-hosted in the repository, removing the dependence to imgur.
  • Recreated all graphs so they accurately show the current benchmarks.
  • Repaired the links in the readme.

What you have to do:
Nothing really. If you like the format and new graphs (have a look at my fork:https://github.com/MauriceGit/skiplist-survey), just accept the pull-request and you're done.

Otherwise re-run the benchmark and re-create the images from your data.

Right now, my implementation is not concurrent so I didn't take the time to create concurrent benchmarks. If I change that, I will create the corresponding benchmarks and make a new pull-request.

Best regards and thanks!
Maurice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant