feat(opsem): use memmssa api to define memin, memout reg for bvopsem2 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyasiddharth
force-pushed
the
memssa-api
branch
from
793d714
to
4c2b69e
Compare
agurfinkel
requested changes
May 29, 2020
include/seahorn/BvOpSem2.hh
Outdated
|
|
||
| public: | ||
| Bv2OpSem(ExprFactory &efac, Pass &pass, const DataLayout &dl, | ||
| TrackLevel trackLvl = MEM); | ||
| Bv2OpSem(ExprFactory &efac, Pass &pass, seadsa::SeaMemorySSA *smssa, |
There was a problem hiding this comment.
pass by const reference
lib/seahorn/BvOpSem2.cc
Outdated
| if (UseMemSSA) { | ||
| seadsa::SeaMemoryAccess *ma = | ||
| m_sem.getSeaMemSSA().getMemoryAccessForShadow(&inst); | ||
| if (auto *pMemUse = dyn_cast<seadsa::SeaMemoryUse>(ma)) { |
There was a problem hiding this comment.
assert(isa<seadsa::SeaMemoryUse>(ma));
auto *pMemUse = cast<seadsa::SeaMemoryUse>(ma);
lib/seahorn/BvOpSem2.cc
Outdated
| m_ctx.setMemTrsfrReadReg(reg); | ||
| m_ctx.setMemScalar(false /* TODO: Make this work */); | ||
| } else { | ||
| LOG("opsem", errs() << "Expected load but sea-dsa does not agree!\n"); |
There was a problem hiding this comment.
same as prior comment. turn into assert
lib/seahorn/BvOpSem2.cc
Outdated
| m_ctx.setMemWriteRegister(memOut); | ||
| m_ctx.setMemScalar(false /* TODO: Make this work */); | ||
| } else { | ||
| LOG("opsem", errs() |
| if (Expr r = getRegister(access)) { | ||
| return r; | ||
| } | ||
| Expr reg; |
There was a problem hiding this comment.
add a comment about handling unique scalars
| @@ -553,7 +554,7 @@ public: | |||
| virtual PtrSortTy mkPtrRegisterSort(const GlobalVariable &gv) const = 0; | |||
|
|
|||
| /// \brief Returns sort of memory-holding register for an instruction | |||
| virtual MemSortTy mkMemRegisterSort(const Instruction &inst) const = 0; | |||
| virtual Expr mkMemRegisterSort(const Value &value) const = 0; | |||
There was a problem hiding this comment.
return type should be MemSortTy. Comment needs to be updated because it talks about instruction.
I would prefer to to not have mkMemRegisterSort for Value. It is easy to abuse and get wrong
There was a problem hiding this comment.
Ok, I see why you are using Value. Add assertions to make sure that only MemSSA or Instruciton are allowed as arguments and nothing else.
Use seamemoryaccess objects to point to the right memory aaray to use instead of relying on shadowmem calls. Currently we use the shadowmem calss as keyto get to seamemoryaccess objects. Also added seamemoryaccess as a terminal
priyasiddharth
force-pushed
the
memssa-api
branch
from
4c2b69e
to
f2d0f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use seamemoryaccess objects to point to the right memory aaray to use instead of relying on shadowmem calls. Currently we use the shadowmem calss as keyto get to seamemoryaccess objects. Also added seamemoryaccess as a terminal