Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warnings #251

Merged
merged 2 commits into from
May 20, 2024
Merged

remove warnings #251

merged 2 commits into from
May 20, 2024

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented May 20, 2024

  • address Ruby "Using the last argument as keyword parameters is deprecated" warning
  • fix the Liquid syntax error that was drowned out by those warnings

lsf37 added 2 commits May 20, 2024 11:50
Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Fixes the Liquid syntax error that was drowned out by the Ruby warnings
before.

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
@lsf37 lsf37 requested a review from Indanz May 20, 2024 01:54
Copy link
Contributor

@Indanz Indanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had these as local mods, but forgot to make a PR.

@Indanz Indanz merged commit 03ca1a8 into master May 20, 2024
8 checks passed
@Indanz Indanz deleted the warning branch May 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants