Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert metadata columns from integer to strings to ensure that SDV works properly #1989

Merged
merged 11 commits into from
May 9, 2024
Merged

Convert metadata columns from integer to strings to ensure that SDV works properly #1989

merged 11 commits into from
May 9, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #1933
CU-86b04u2ae

Metadata columns need to be strings as much of SDV metadata detection assumes all columns are of string type

@lajohn4747 lajohn4747 requested a review from a team as a code owner May 6, 2024 16:47
@sdv-team
Copy link
Contributor

sdv-team commented May 6, 2024

Task linked: CU-86b04u2ae SDV - Metadata detection crashes when the column names are integers (TypeError: unsupported operand type(s)) #1933

amontanez24
amontanez24 reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an integration test for both the single and multi table case?

sdv/multi_table/hma.py Outdated Show resolved Hide resolved
R-Palazzo
R-Palazzo approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/integration/single_table/test_base.py Show resolved Hide resolved
@lajohn4747 lajohn4747 merged commit bfa6e72 into main May 9, 2024
37 checks passed
@lajohn4747 lajohn4747 deleted the issue_1933_metadata_detection branch May 9, 2024 23:40
@lajohn4747 lajohn4747 changed the title Convert metadata columns from integer to columns to ensure that SDV works properly Convert metadata columns from integer to strings to ensure that SDV works properly May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@R-Palazzo R-Palazzo R-Palazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@lajohn4747 @sdv-team @amontanez24 @R-Palazzo