Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include sdv_logger_config.yml with the package #1963

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Include sdv_logger_config.yml with the package #1963

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d88250f
Include logging configuration
pvk-developer Apr 26, 2024
23b6ab1
Use macos11 for 3.8
pvk-developer Apr 26, 2024
e1f89bd
Fix breaking load compatibility
pvk-developer Apr 26, 2024
fc142b5
Remove table_name
pvk-developer Apr 26, 2024
993ccf8
Bump minimum version of numpy for python <3.10
pvk-developer Apr 26, 2024
6edd64f
Bump pandas minimum version
pvk-developer Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdv/sequential/par.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,13 @@ def _get_context_metadata(self):

def __init__(self, metadata, enforce_min_max_values=True, enforce_rounding=False,
locales=['en_US'], context_columns=None, segment_size=None, epochs=128,
sample_size=1, cuda=True, verbose=False):
sample_size=1, cuda=True, verbose=False, table_name=None):
amontanez24 marked this conversation as resolved.
Show resolved Hide resolved
super().__init__(
metadata=metadata,
enforce_min_max_values=enforce_min_max_values,
enforce_rounding=enforce_rounding,
locales=locales
locales=locales,
table_name=table_name
)

sequence_key = self.metadata.sequence_key
Expand Down
19 changes: 9 additions & 10 deletions sdv/single_table/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,16 +500,15 @@ def load(cls, filepath):
if getattr(synthesizer, '_synthesizer_id', None) is None:
synthesizer._synthesizer_id = generate_synthesizer_id(synthesizer)

if synthesizer.table_name is None:
SYNTHESIZER_LOGGER.info(
'\nLoad:\n'
' Timestamp: %s\n'
' Synthesizer class name: %s\n'
' Synthesizer id: %s',
datetime.datetime.now(),
synthesizer.__class__.__name__,
synthesizer._synthesizer_id,
)
SYNTHESIZER_LOGGER.info(
'\nLoad:\n'
' Timestamp: %s\n'
' Synthesizer class name: %s\n'
' Synthesizer id: %s',
datetime.datetime.now(),
synthesizer.__class__.__name__,
synthesizer._synthesizer_id,
)

return synthesizer

Expand Down
3 changes: 2 additions & 1 deletion tests/unit/sequential/test_par.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ def test_get_parameters(self):
'epochs': 10,
'sample_size': 5,
'cuda': False,
'verbose': False
'verbose': False,
'table_name': None
}

def test_get_metadata(self):
Expand Down