Use formatter keyword in yml

sdv-dev · May 15, 2024 · 42abd0e · 42abd0e
1 parent 9025dd1
commit 42abd0e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/sdv/logging/logger.py b/sdv/logging/logger.py
@@ -59,14 +59,14 @@ def get_sdv_logger(logger_name):
             logger.removeHandler(handler)
 
         if logger_name in logger_conf.get('loggers'):
-            formatter = None
+            formatter = None            
             config = logger_conf.get('loggers').get(logger_name)
             log_level = getattr(logging, config.get('level', 'INFO'))
-            if config.get('format'):
-                if config.get('format') == 'CSV':
+            if config.get('formatter'):
+                if config.get('formatter') == 'sdv.logging.logger.CSVFormatter':
                     formatter = CSVFormatter()
-                else:
-                    formatter = logging.Formatter(config.get('format'))
+            elif config.get('format'):
+                formatter = logging.Formatter(config.get('format'))
 
             logger.setLevel(log_level)
             logger.propagate = config.get('propagate', False)

diff --git a/sdv/logging/sdv_logger_config.yml b/sdv/logging/sdv_logger_config.yml
@@ -4,28 +4,28 @@ loggers:
   SingleTableSynthesizer:
     level: INFO
     propagate: false
-    format: CSV
+    formatter: sdv.logging.logger.CSVFormatter
     handlers:
       class: logging.FileHandler
       filename: sdv_logs.csv
   MultiTableSynthesizer:
     level: INFO
     propagate: false
-    format: CSV
+    formatter: sdv.logging.logger.CSVFormatter
     handlers:
       class: logging.FileHandler
       filename: sdv_logs.csv
     MultiTableMetadata:
       level: INFO
       propagate: false
-      format: CSV
+      formatter: sdv.logging.logger.CSVFormatter
       handlers:
         class: logging.FileHandler
         filename: sdv_logs.csv
     SingleTableMetadata:
       level: INFO
       propagate: false
-      format: CSV
+      formatter: sdv.logging.logger.CSVFormatter
       handlers:
         class: logging.FileHandler
         filename: sdv_logs.csv
diff --git a/tests/unit/logging/test_logger.py b/tests/unit/logging/test_logger.py
@@ -70,7 +70,7 @@ def test_get_sdv_logger_csv(mock_get_sdv_logger_config, mock_getlogger,
         'loggers': {
             'test_logger_csv': {
                 'level': 'DEBUG',
-                'format': 'CSV',
+                'formatter': 'sdv.logging.logger.CSVFormatter',
                 'handlers': {
                     'filename': 'logfile.csv',
                     'class': 'logging.FileHandler'