Return ax where possible for integration with matplotlib #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
noamsgl
reviewed
Dec 30, 2021
| @@ -93,6 +93,8 @@ def compare_2d(real, synth, columns=None, figsize=None): | |||
| ax = real.plot.scatter(x, y, color='blue', alpha=0.5, figsize=figsize) | |||
| ax = synth.plot.scatter(x, y, ax=ax, color='orange', alpha=0.5, figsize=figsize) | |||
| ax.legend(['Real', 'Synthetic']) | |||
|
|
|||
| return ax | |||
There was a problem hiding this comment.
I have a learning question. Why does this help integrate better with matplotlib?
There was a problem hiding this comment.
@noamsgl I'm new to this too - I think it allows people to reuse the resulting matplotlib.axes.Axes object and make more changes to it as they see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.