WIP: Remove C tests and replace by Rust tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 14, 2021
sdroege
force-pushed
the
no-c-tests
branch
5 times, most recently
from
f9acccf
to
04cb872
Compare
sdroege
force-pushed
the
no-c-tests
branch
2 times, most recently
from
809b26c
to
a5d9ed8
Compare
The implementation is proven to be equivalent to the C implementation now and faster in any meaningful way so simplify the build system and get rid of the C code. Next various unit tests have to be added for the removed comparison tests to ensure no regressions in the future. Fixes #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.