Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace C tests with Rust tests for the individual components and get rid of all C dependencies #37

Open
sdroege opened this issue Nov 10, 2020 · 0 comments
Open

Replace C tests with Rust tests for the individual components and get rid of all C dependencies #37

sdroege opened this issue Nov 10, 2020 · 0 comments
Assignees
@sdroege

Comments

@sdroege
Copy link
Owner

sdroege commented Nov 10, 2020

From here:

I think at some point we should simply drop the C tests as long as we have new tests that cover all the components equally well. The implementation is diverging a lot from the C implementation already and at some point keeping the outputs similar enough with all the floating point inaccuracies depending on operation order/etc this is going to be annoying to maintain.
@sdroege sdroege mentioned this issue Nov 10, 2020
Merged
sdroege added a commit that referenced this issue Feb 14, 2021
@sdroege
Remove C comparison tests and benchmarks
9994e5b 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
sdroege added a commit that referenced this issue Feb 14, 2021
@sdroege
Remove C comparison tests and benchmarks
bce6845 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
@sdroege sdroege self-assigned this Feb 14, 2021
@sdroege sdroege linked a pull request Feb 14, 2021 that will close this issue
WIP: Remove C tests and replace by Rust tests #39
Closed
sdroege added a commit that referenced this issue Feb 14, 2021
@sdroege
Remove C comparison tests and benchmarks
9fc28e4 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
sdroege added a commit that referenced this issue Feb 14, 2021
@sdroege
Remove C comparison tests and benchmarks
3491369 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
sdroege added a commit that referenced this issue Feb 14, 2021
@sdroege
Remove C comparison tests and benchmarks
73e2222 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
sdroege added a commit that referenced this issue Feb 14, 2021
@sdroege
Remove C comparison tests and benchmarks
3d5b5c0 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
sdroege added a commit that referenced this issue Feb 28, 2021
@sdroege
Remove C comparison tests and benchmarks
a5d9ed8 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
sdroege added a commit that referenced this issue Feb 28, 2021
@sdroege
Remove C comparison tests and benchmarks
f609605 
The implementation is proven to be equivalent to the C implementation
now and faster in any meaningful way so simplify the build system and
get rid of the C code.

Next various unit tests have to be added for the removed comparison
tests to ensure no regressions in the future.

Fixes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdroege sdroege

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Remove C tests and replace by Rust tests sdroege/ebur128
1 participant
@sdroege