Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Name and Version as Theme Properties #1752

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Videowelder
Copy link

Working on a theme that displays the detected OS as a graphical design element, much like some distros did with lightdm in the past.
Figured these properties would be of use on the official project for other theme designers.
These use built-in Qt stuff, so wide support and no maintenance required.

Copy link
Contributor

@Vogtinator Vogtinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be implemented solely in the greeter, no need to touch the daemon at all

@Vogtinator
Copy link
Contributor

IMO QSysInfo::prettyProductName() is the most important one and should be available as well.

Then we have three new properties, at which point it might be a good idea to use an object with properties instead, allowing for use from QML like this:

console.log("OS: " + sddm.os.prettyName + " Version: " + sddm.os.version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants