docker: drop jmx and tools-java from installation #18566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykaul
reviewed
May 8, 2024
| @@ -69,9 +69,6 @@ packages=( | |||
| "build/dist/$config/debian/$product-conf_$version-$release-1_$arch.deb" | |||
| "build/dist/$config/debian/$product-kernel-conf_$version-$release-1_$arch.deb" | |||
There was a problem hiding this comment.
why do we need kernel configuration inside the docker image? What does it do?
There was a problem hiding this comment.
It's one of Scylla-server dependency
mykaul
reviewed
May 8, 2024
dist/docker/debian/build_docker.sh
Outdated
| @@ -98,7 +95,7 @@ run apt-get -y upgrade | |||
| run apt-get -y --no-install-suggests install dialog apt-utils | |||
| run bash -ec "echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections" | |||
| run bash -ec "rm -rf /etc/rsyslog.conf" | |||
| run apt-get -y --no-install-suggests install hostname supervisor openjdk-11-jre-headless python2 python3 python3-yaml curl rsyslog sudo | |||
| run apt-get -y --no-install-suggests install hostname supervisor python2 python3 python3-yaml curl rsyslog sudo | |||
There was a problem hiding this comment.
who's still using python2? (unrelated to this issue of course)
There was a problem hiding this comment.
Based on 27e3266 it's related, I can remove it now
Following the work done in dd07796, removing the scylla-jmx and scylla-tools-java from our docker image
yaronkaikov
force-pushed
the
drop-jmx-tools-from-docker
branch
from
feb5208
to
01a4f1d
Compare
🟢 CI State: SUCCESS✅ - Build Build Details:
|
denesb
approved these changes
May 9, 2024
|
@scylladb/scylla-maint can you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work done in dd07796, removing the Scylla-jmx and Scylla-tools-java from our docker image