Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize e2e command #1824

Merged
merged 1 commit into from May 15, 2024
Merged

Parametrize e2e command #1824

merged 1 commit into from May 15, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Mar 12, 2024

This allows for reusing e2e server and runner in other commands.

@zimnx zimnx added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 12, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
@zimnx zimnx force-pushed the mz/parametrize-e2es branch 2 times, most recently from 0f0a1b3 to 1fcb2b8 Compare March 15, 2024 13:01
tnozicka
tnozicka reviewed Mar 21, 2024
View reviewed changes
pkg/cmd/tests/tests.go Outdated Show resolved Hide resolved
pkg/test/e2e/cmd.go Outdated Show resolved Hide resolved
rzetelskik
rzetelskik approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@zimnx zimnx requested a review from tnozicka March 26, 2024 13:57
@zimnx
Copy link
Collaborator Author

zimnx commented Mar 26, 2024

Cluster provisioning failed + manager flake #1694 (comment)
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Mar 26, 2024

Cluster provisioning failed
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Mar 26, 2024

manager flake #1694 (comment)
/retest

@zimnx zimnx force-pushed the mz/parametrize-e2es branch 2 times, most recently from 714a412 to 39786a3 Compare April 2, 2024 12:29
@zimnx
Copy link
Collaborator Author

zimnx commented Apr 2, 2024

Manager flake #1694 (comment)
/override ci/prow/e2e-gke-release-script-latest
/retest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@zimnx: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/e2e-gke-release-script-latest

Only the following failed contexts/checkruns were expected:

  • ci/prow/build
  • ci/prow/docs
  • ci/prow/e2e-gke-parallel
  • ci/prow/e2e-gke-parallel-clusterip
  • ci/prow/e2e-gke-serial
  • ci/prow/helm-build
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • ci/prow/verify-vendorability
  • pull-scylla-operator-master-build
  • pull-scylla-operator-master-docs
  • pull-scylla-operator-master-e2e-gke-parallel
  • pull-scylla-operator-master-e2e-gke-parallel-clusterip
  • pull-scylla-operator-master-e2e-gke-serial
  • pull-scylla-operator-master-helm-build
  • pull-scylla-operator-master-images
  • pull-scylla-operator-master-unit
  • pull-scylla-operator-master-verify
  • pull-scylla-operator-master-verify-deps
  • pull-scylla-operator-master-verify-vendorability
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

Manager flake #1694 (comment)
/override ci/prow/e2e-gke-release-script-latest
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimnx
Copy link
Collaborator Author

zimnx commented Apr 3, 2024

Flake -#1525 (comment)
/retest

tnozicka
tnozicka reviewed Apr 16, 2024
View reviewed changes
pkg/cmd/tests/tests_run.go Outdated Show resolved Hide resolved
pkg/cmd/tests/tests_run.go Outdated Show resolved Hide resolved
pkg/cmd/tests/tests_run.go Outdated Show resolved Hide resolved
@scylla-operator-bot scylla-operator-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@zimnx zimnx requested a review from tnozicka April 16, 2024 16:32
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@zimnx
Copy link
Collaborator Author

zimnx commented Apr 18, 2024

manager flake
/retest

tnozicka
tnozicka reviewed Apr 18, 2024
View reviewed changes
pkg/cmd/tests/options.go Outdated Show resolved Hide resolved
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 23, 2024
tnozicka
tnozicka requested changes May 3, 2024
View reviewed changes
pkg/cmd/tests/options.go Outdated Show resolved Hide resolved
tnozicka
tnozicka reviewed May 6, 2024
View reviewed changes
pkg/cmd/tests/tests_run.go Show resolved Hide resolved
pkg/cmd/tests/tests_run.go Outdated Show resolved Hide resolved
@zimnx zimnx requested a review from tnozicka May 9, 2024 13:03
tnozicka
tnozicka reviewed May 10, 2024
View reviewed changes
pkg/cmd/tests/tests_run.go Outdated Show resolved Hide resolved
pkg/cmd/tests/tests_run.go Outdated Show resolved Hide resolved
@zimnx
Parametrize e2e command
ebd5630 
This allows for reusing e2e server and runner in other commands.
@tnozicka
Copy link
Member

thanks for the updates
/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Copy link
Collaborator Author

zimnx commented May 15, 2024

apiserver died + manager flake
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented May 15, 2024

/test images
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented May 15, 2024

Flake - #1028 (comment)
/retest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented May 15, 2024 •
edited

@zimnx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 714a412 link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zimnx
Copy link
Collaborator Author

zimnx commented May 15, 2024

/test images
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 838ee10 into scylladb:master May 15, 2024
12 checks passed
@zimnx zimnx deleted the mz/parametrize-e2es branch May 15, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka requested changes

@rzetelskik rzetelskik rzetelskik approved these changes

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimnx @tnozicka @rzetelskik