Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ClusterIP traffic to inter-node communication port before CQL is ready #1614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 24 additions & 1 deletion deploy/operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ rules:
- ""
resources:
- nodes
- endpoints
verbs:
- get
- list
Expand Down Expand Up @@ -283,6 +282,30 @@ rules:
- patch
- update
- delete
- apiGroups:
- discovery.k8s.io
resources:
- endpointslices
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- endpoints
verbs:
- create
- delete
- get
- list
- patch
- update
- watch

---
apiVersion: v1
Expand Down
25 changes: 24 additions & 1 deletion deploy/operator/00_clusterrole_def.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ rules:
- ""
resources:
- nodes
- endpoints
verbs:
- get
- list
Expand Down Expand Up @@ -273,3 +272,27 @@ rules:
- patch
- update
- delete
- apiGroups:
- discovery.k8s.io
resources:
- endpointslices
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- endpoints
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
25 changes: 24 additions & 1 deletion helm/scylla-operator/templates/clusterrole_def.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ rules:
- ""
resources:
- nodes
- endpoints
verbs:
- get
- list
Expand Down Expand Up @@ -273,3 +272,27 @@ rules:
- patch
- update
- delete
- apiGroups:
- discovery.k8s.io
resources:
- endpointslices
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- endpoints
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
2 changes: 2 additions & 0 deletions pkg/cmd/operator/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ func (o *OperatorOptions) run(ctx context.Context, streams genericclioptions.IOS
kubeInformers.Policy().V1().PodDisruptionBudgets(),
kubeInformers.Networking().V1().Ingresses(),
kubeInformers.Batch().V1().Jobs(),
kubeInformers.Discovery().V1().EndpointSlices(),
kubeInformers.Core().V1().Endpoints(),
scyllaInformers.Scylla().V1().ScyllaClusters(),
o.OperatorImage,
o.CQLSIngressPort,
Expand Down
4 changes: 4 additions & 0 deletions pkg/controller/scyllacluster/conditions.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,8 @@ const (
jobControllerDegradedCondition = "JobControllerDegraded"
configControllerProgressingCondition = "ConfigControllerProgressing"
configControllerDegradedCondition = "ConfigControllerDegraded"
endpointSliceControllerProgressingCondition = "EndpointSliceControllerProgressing"
endpointSliceControllerDegradedCondition = "EndpointSliceControllerDegraded"
tnozicka marked this conversation as resolved.
Show resolved Hide resolved
endpointsControllerProgressingCondition = "EndpointsControllerProgressing"
endpointsControllerDegradedCondition = "EndpointsControllerDegraded"
)
69 changes: 69 additions & 0 deletions pkg/controller/scyllacluster/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
appsv1 "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
discoveryv1 "k8s.io/api/discovery/v1"
networkingv1 "k8s.io/api/networking/v1"
policyv1 "k8s.io/api/policy/v1"
rbacv1 "k8s.io/api/rbac/v1"
Expand All @@ -29,6 +30,7 @@ import (
appsv1informers "k8s.io/client-go/informers/apps/v1"
batchv1informers "k8s.io/client-go/informers/batch/v1"
corev1informers "k8s.io/client-go/informers/core/v1"
discoveryv1informers "k8s.io/client-go/informers/discovery/v1"
networkingv1informers "k8s.io/client-go/informers/networking/v1"
policyv1informers "k8s.io/client-go/informers/policy/v1"
rbacv1informers "k8s.io/client-go/informers/rbac/v1"
Expand All @@ -37,6 +39,7 @@ import (
appsv1listers "k8s.io/client-go/listers/apps/v1"
batchv1listers "k8s.io/client-go/listers/batch/v1"
corev1listers "k8s.io/client-go/listers/core/v1"
discoveryv1listers "k8s.io/client-go/listers/discovery/v1"
networkingv1listers "k8s.io/client-go/listers/networking/v1"
policyv1listers "k8s.io/client-go/listers/policy/v1"
rbacv1listers "k8s.io/client-go/listers/rbac/v1"
Expand Down Expand Up @@ -76,6 +79,8 @@ type Controller struct {
ingressLister networkingv1listers.IngressLister
scyllaLister scyllav1listers.ScyllaClusterLister
jobLister batchv1listers.JobLister
endpointSliceLister discoveryv1listers.EndpointSliceLister
endpointsLister corev1listers.EndpointsLister

cachesToSync []cache.InformerSynced

Expand All @@ -100,6 +105,8 @@ func NewController(
pdbInformer policyv1informers.PodDisruptionBudgetInformer,
ingressInformer networkingv1informers.IngressInformer,
jobInformer batchv1informers.JobInformer,
endpointSliceInformer discoveryv1informers.EndpointSliceInformer,
endpointsInformer corev1informers.EndpointsInformer,
scyllaClusterInformer scyllav1informers.ScyllaClusterInformer,
operatorImage string,
cqlsIngressPort int,
Expand Down Expand Up @@ -127,6 +134,8 @@ func NewController(
ingressLister: ingressInformer.Lister(),
scyllaLister: scyllaClusterInformer.Lister(),
jobLister: jobInformer.Lister(),
endpointSliceLister: endpointSliceInformer.Lister(),
endpointsLister: endpointsInformer.Lister(),

cachesToSync: []cache.InformerSynced{
podInformer.Informer().HasSynced,
Expand All @@ -140,6 +149,8 @@ func NewController(
ingressInformer.Informer().HasSynced,
scyllaClusterInformer.Informer().HasSynced,
jobInformer.Informer().HasSynced,
endpointSliceInformer.Informer().HasSynced,
endpointsInformer.Informer().HasSynced,
},

eventRecorder: eventBroadcaster.NewRecorder(scheme.Scheme, corev1.EventSource{Component: "scyllacluster-controller"}),
Expand Down Expand Up @@ -235,6 +246,18 @@ func NewController(
DeleteFunc: scc.deleteJob,
})

endpointSliceInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: scc.addEndpointSlice,
UpdateFunc: scc.updateEndpointSlice,
DeleteFunc: scc.deleteEndpointSlice,
})

endpointsInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: scc.addEndpoints,
UpdateFunc: scc.updateEndpoints,
DeleteFunc: scc.deleteEndpoints,
})

return scc, nil
}

Expand Down Expand Up @@ -625,3 +648,49 @@ func (scc *Controller) deleteJob(obj interface{}) {
scc.handlers.EnqueueOwner,
)
}

func (scc *Controller) addEndpointSlice(obj interface{}) {
scc.handlers.HandleAdd(
obj.(*discoveryv1.EndpointSlice),
scc.handlers.EnqueueOwner,
)
}

func (scc *Controller) updateEndpointSlice(old, cur interface{}) {
scc.handlers.HandleUpdate(
old.(*discoveryv1.EndpointSlice),
cur.(*discoveryv1.EndpointSlice),
scc.handlers.EnqueueOwner,
scc.deleteEndpointSlice,
)
}

func (scc *Controller) deleteEndpointSlice(obj interface{}) {
scc.handlers.HandleDelete(
obj,
scc.handlers.EnqueueOwner,
)
}

func (scc *Controller) addEndpoints(obj interface{}) {
scc.handlers.HandleAdd(
obj.(*corev1.Endpoints),
scc.handlers.EnqueueOwner,
)
}

func (scc *Controller) updateEndpoints(old, cur interface{}) {
scc.handlers.HandleUpdate(
old.(*corev1.Endpoints),
cur.(*corev1.Endpoints),
scc.handlers.EnqueueOwner,
scc.deleteEndpoints,
)
}

func (scc *Controller) deleteEndpoints(obj interface{}) {
scc.handlers.HandleDelete(
obj,
scc.handlers.EnqueueOwner,
)
}