exit with 1 when Exception catched and raise exception when HTTP error code is client error #511
Conversation
|
@syuu1228 I have changed to base branch to |
|
Also please paste your verification |
|
@syuu1228 ping |
|
@syuu1228 please rebase and run verification |
On scylladb#498, status of scylla-image-post-start.service is NOT "failed" even the script causing error, because scylla_post_start.py catches all exceptions and just logging it, so the script finishes without error. To getting notify users the script failed operation during running, we should sys.exit(1) when the exception catched. fixes scylladb#505
When curl catched HTTP error 4xx = client error such as "404 Not Found" or "403 Forbidden", it likely our script bug not server side issue, we should re-raise exception immediately instead of retrying. related scylladb#505
syuu1228
force-pushed
the
exit_1_when_http_error_occurs
branch
from
003f509
to
2522ec8
Compare
|
Rebased, running next-machine-image at: |
|
@syuu1228 Running full verification failed twice, https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/330/ , please make sure it's not related to your changes |
|
I found that full verification actually can pass with May 27, 2024 version of scylla-master/next build (It was the latest build on scylla-master/next when I tested). Test result: https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/339/ I guess the error is not related this patch. |
|
On #498, status of scylla-image-post-start.service is NOT "failed" even
the script causing error, because scylla_post_start.py catches all
exceptions and just logging it, so the script finishes without error.
To getting notify users the script failed operation during running, we
should sys.exit(1) when the exception catched.
Also, when curl catched HTTP error 4xx = client error such as "404 Not Found"
or "403 Forbidden", it likely our script bug not server side issue, we
should re-raise exception immediately instead of retrying.
fixes #505