[DRAFT] Add python type hinting on our scripts and run type checking #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce runtime error on our code, and also improve code stability, add python type hinting on python code, and run type checking on github CI.
fruch
reviewed
May 10, 2023
| @@ -26,6 +26,9 @@ jobs: | |||
| pip install -r test-requirements.txt | |||
| pytest ./tests | |||
|
|
|||
| - name: mypy | |||
| run: mypy . | |||
There was a problem hiding this comment.
this can be an overkill, you gonna have lots and lot of things to fix to make it work.
I would recommend starting with something like ruff, slowly.
There was a problem hiding this comment.
Can we see what we actually get running it manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce runtime error on our code, and also improve code stability, add python type hinting on python code, and run type checking on github CI.