Add SSL support to schemagen #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds SSL support to the schemagen command in order to generate table models for Cassandra/Scylla clusters that require SSL/TLS encryption. The motivation behind this change is to align with the SSL requirements of AWS Keyspaces.
Changes Made
Added the
flagSslPathflag to allow users to specify the path to a directory containing SSL certificates.Modified the
createSession()function to include SSL options in the cluster configuration if theflagSslPathflag is provided.Configured SSL options with the provided certificate path and disabled host verification to ensure compatibility with AWS Keyspaces SSL settings.
Testing
I have manually tested this feature by generating table models for an AWS Keyspaces cluster with SSL enabled. The models were successfully generated without any errors.
Related Issue(s)
N/A
Please review this pull request and consider merging it into the main branch.
Thank you.