Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing in custom columns for insert stmt #250

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support passing in custom columns for insert stmt #250

wants to merge 3 commits into from

Conversation

YeminLi
Copy link
Contributor

@YeminLi YeminLi commented Feb 2, 2023 •
edited

Hello,

In the PR we are adding support for passing in custom columns for insertion, instead of always inserting all columns.

Please have a look and let me know for any questions.

Thanks!

Gor027
Gor027 approved these changes Feb 15, 2023
View reviewed changes
Copy link

@Gor027 Gor027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avelanarius I think this PR looks good to be merged.

@zimnx
Copy link
Collaborator

zimnx commented Feb 15, 2023

Please squash commits before merge, and explain what these changes are brining it commit description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gor027 Gor027 Gor027 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YeminLi @zimnx @Gor027