Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): change base module to support jax device removal #2787

Merged
merged 3 commits into from
May 15, 2024

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented May 9, 2024

jax 0.4.27 removed the device method of arrays in favor of devices, in order to add support for distributed cpu. this method has been deprecated since jax 0.4.21.

the strategy here may need to be adjusted for multi device settings as we currently just return the first device.

@martinkim0 martinkim0 added on-merge: backport to 1.1.x on-merge: backport to 1.1.x on-merge: backport to 1.2.x on-merge: backport to 1.2.x labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.87%. Comparing base (3087178) to head (ee8dfc1).
Report is 4 commits behind head on main.

❗ Current head ee8dfc1 differs from pull request most recent head 877483d. Consider uploading reports for the commit 877483d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2787      +/-   ##
==========================================
- Coverage   88.90%   88.87%   -0.03%     
==========================================
  Files         161      161              
  Lines       13339    13342       +3     
==========================================
- Hits        11859    11858       -1     
- Misses       1480     1484       +4     
Files Coverage Δ
src/scvi/module/base/_base_module.py 93.91% <75.00%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes

@martinkim0 martinkim0 changed the title fix(module): change base module to support jax device removal feat(module): change base module to support jax device removal May 15, 2024
@martinkim0 martinkim0 merged commit 0334c44 into main May 15, 2024
10 of 11 checks passed
@martinkim0 martinkim0 deleted the jax-fix branch May 15, 2024 17:26
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request May 15, 2024
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request May 15, 2024
martinkim0 added a commit that referenced this pull request May 15, 2024
…o support jax device removal) (#2794)

Backport PR #2787: feat(module): change base module to support jax
device removal

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
martinkim0 added a commit that referenced this pull request May 15, 2024
…o support jax device removal) (#2795)

Backport PR #2787: feat(module): change base module to support jax
device removal

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.1.x on-merge: backport to 1.1.x on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant