Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): set up cirun for gpu tests #2618

Closed
wants to merge 5 commits into from
Closed

feat(ci): set up cirun for gpu tests #2618

wants to merge 5 commits into from

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Mar 19, 2024

adds a cirun configuration for GPU tests. given that certain instances may not be available during testing time as well as initialization taking a while, I think it only makes sense to use cirun/aws for multi-gpu tests and keep single-gpu ones on self-hosted.

@martinkim0 martinkim0 added on-merge: backport to 1.1.x on-merge: backport to 1.1.x cuda tests Run test suite on CUDA on-merge: backport to 1.2.x on-merge: backport to 1.2.x labels Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (f53c01a) to head (c85456b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
- Coverage   89.18%   88.69%   -0.50%     
==========================================
  Files         159      159              
  Lines       13308    13309       +1     
==========================================
- Hits        11869    11804      -65     
- Misses       1439     1505      +66     

see 3 files with indirect coverage changes

@martinkim0 martinkim0 closed this May 1, 2024
@martinkim0 martinkim0 deleted the ci-run branch May 1, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA on-merge: backport to 1.1.x on-merge: backport to 1.1.x on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant