DestVI changed l1 loss. Expected proportions #1591
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
- Coverage 89.18% 88.94% -0.25%
==========================================
Files 152 152
Lines 12482 12536 +54
==========================================
+ Hits 11132 11150 +18
- Misses 1350 1386 +36 ☔ View full report in Codecov by Sentry. |
justjhong
reviewed
Jul 5, 2022
|
@cane11 any reason to keep this open? |
canergen
force-pushed
the
can-destvi-expected
branch
from
365a4a0
to
34e03d6
Compare
|
@martinkim0 It's the version of destVI we are using for Curio data (other sparsity regularization). Can you have a pass? |
for more information, see https://pre-commit.ci
…-tools into can-destvi-expected
martinkim0
reviewed
Dec 8, 2023
| @@ -78,7 +78,7 @@ def __init__( | |||
| n_latent: int, | |||
| n_layers: int, | |||
| dropout_decoder: float, | |||
| l1_reg: float, | |||
| celltype_reg: dict, | |||
There was a problem hiding this comment.
I feel like this argument would be clearer if we separate it out into two arguments: celltype_regularization: Literal["l1", "entropy"] | None = None and celltype_regularization_weight: float | None = None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses proportions computed in other deconvolution method to infer cell activation state of those cells. Application activation for e.g. Cell2Location results. L1 loss changed. Still in discussion.
Optional obsm field.